feat: gate allocation on accepted proposals

This commit is contained in:
Josh Creek
2026-09-01 10:18:22 +01:00
parent 2d750cbcab
commit 11599889fa
4 changed files with 72 additions and 2 deletions
+38
View File
@@ -63,6 +63,44 @@ func TestServiceDoesNotReturnProviderResultAfterDurableFailure(t *testing.T) {
}
}
func TestServiceAllocatesOnlyUnanimouslyAcceptedMatchingProposal(t *testing.T) {
proposal := domain.Proposal{
ProposalID: "proposal-1", Playlist: domain.Casual, State: domain.Accepted,
Participants: []domain.ProposalParticipant{
{PlayerID: "player-a", Response: domain.AcceptedResponse},
{PlayerID: "player-b", Response: domain.AcceptedResponse},
},
}
provider := &providerSpy{result: agones.AllocatedServer{Allocation: domain.Allocation{AllocationID: "a", MatchID: "m", State: domain.ServerAllocated}, Endpoint: "127.0.0.1:7777"}}
durable := &durableSpy{}
service := Service{Provider: provider, Durable: durable, Now: func() time.Time { return time.Unix(1000, 0) }}
request := domain.AllocationRequest{AllocationID: "a", MatchID: "m", Region: "EU", Build: "b", Protocol: 1, Transport: "enet"}
if _, err := service.AllocateAcceptedProposal(context.Background(), proposal, request, domain.Casual, map[string]string{"region": "EU"}); err != nil {
t.Fatalf("accepted proposal was rejected: %v", err)
}
if provider.calls != 1 || durable.calls != 1 {
t.Fatalf("provider/durable calls = %d/%d", provider.calls, durable.calls)
}
for name, mutate := range map[string]func(*domain.Proposal){
"open": func(p *domain.Proposal) { p.State = domain.Open },
"wrong-playlist": func(p *domain.Proposal) { p.Playlist = domain.Ranked },
"pending": func(p *domain.Proposal) { p.Participants[0].Response = domain.Pending },
"duplicate": func(p *domain.Proposal) { p.Participants[1].PlayerID = p.Participants[0].PlayerID },
} {
invalid := proposal
invalid.Participants = append([]domain.ProposalParticipant(nil), proposal.Participants...)
mutate(&invalid)
before := provider.calls
if _, err := service.AllocateAcceptedProposal(context.Background(), invalid, request, domain.Casual, map[string]string{"region": "EU"}); err == nil {
t.Fatalf("%s proposal was accepted", name)
}
if provider.calls != before {
t.Fatalf("%s proposal reached provider", name)
}
}
}
func TestServicePublishesRosterOnlyForAllocatedAssignment(t *testing.T) {
roster := &rosterSpy{}
service := Service{Roster: roster}