fix(multiplayer): reject websocket caps before upgrade

server/api/events.go

@@ -161,6 +161,13 @@ func (s *Service) controlPlaneEvent(w http.ResponseWriter, r *http.Request) {
 	if !ok {
 		return
 	}
+	hub := s.getEventHub()
+	subscriber := hub.subscribe(playerID)
+	if subscriber == nil {
+		writeError(w, http.StatusTooManyRequests, "websocket_connection_limited")
+		return
+	}
+	defer hub.unsubscribe(subscriber)
 	hijacker, ok := w.(http.Hijacker)
 	if !ok {
 		writeError(w, http.StatusNotImplemented, "websocket_unavailable")
@@ -178,12 +185,6 @@ func (s *Service) controlPlaneEvent(w http.ResponseWriter, r *http.Request) {
 	if err := buffered.Flush(); err != nil {
 		return
 	}
-	subscriber := s.getEventHub().subscribe(playerID)
-	if subscriber == nil {
-		return
-	}
-	defer s.getEventHub().unsubscribe(subscriber)
-
 	var writeMu sync.Mutex
 	done := make(chan struct{})
 	go func() {

server/api/events_connection_test.go

@@ -1,6 +1,10 @@
 package api
 
-import "testing"
+import (
+	"net/http"
+	"net/http/httptest"
+	"testing"
+)
 
 func TestEventHubCapsConnectionsPerPlayerAndReleasesCapacity(t *testing.T) {
 	hub := newEventHub()
@@ -20,3 +24,23 @@ func TestEventHubCapsConnectionsPerPlayerAndReleasesCapacity(t *testing.T) {
 	}
 	hub.unsubscribe(second)
 }
+
+func TestEventConnectionCapReturnsHTTP429BeforeUpgrade(t *testing.T) {
+	service := &Service{SessionBackend: &sessionBackendSpy{}}
+	hub := service.getEventHub()
+	first := hub.subscribe("player-1")
+	second := hub.subscribe("player-1")
+	defer hub.unsubscribe(first)
+	defer hub.unsubscribe(second)
+	request := httptest.NewRequest(http.MethodGet, "/v1/events", nil)
+	request.Header.Set("Upgrade", "websocket")
+	request.Header.Set("Connection", "Upgrade")
+	request.Header.Set("Sec-WebSocket-Version", "13")
+	request.Header.Set("Sec-WebSocket-Key", "dGhlIHNhbXBsZSBub25jZQ==")
+	request.Header.Set("Authorization", "Bearer session-1:token-1")
+	recorder := httptest.NewRecorder()
+	service.controlPlaneEvent(recorder, request)
+	if recorder.Code != http.StatusTooManyRequests {
+		t.Fatalf("connection-cap status = %d, want 429", recorder.Code)
+	}
+}