fix(kind): validate the allocation response Agones actually returns

With the Fleet readiness wait corrected, the gate reached the allocation
check for the first time and failed with "allocation did not return a
GameServer" -- while the cluster dump shows the allocation plainly
succeeded: one GameServer Allocated, Fleet reporting ALLOCATED 1.

GameServerAllocationStatus is flat: state, gameServerName, address,
ports, nodeName. It does not embed the allocated GameServer. The
validator read status.gameServer.metadata.name and
status.gameServer.status.{address,ports}, a shape Agones never sends,
and its unit tests asserted that same invented shape -- so validator and
tests agreed with each other while both disagreed with Agones. Nothing
caught it because the gate had never once allocated anything.

Read the real fields, keeping every existing check: non-empty name,
address neither blank nor unspecified, exactly one named "game" port in
range.

Also print the response body when validation fails. work_dir is removed
by the EXIT trap, so a shape mismatch was otherwise invisible from CI --
which is how this survived. If the shape is still not what I expect, the
next run says so instead of costing another round trip.
This commit is contained in:
Josh Creek
2026-09-05 22:03:41 +01:00
parent 4f48f0a6a8
commit 52ee181042
3 changed files with 34 additions and 25 deletions
+12 -12
View File
@@ -11,26 +11,26 @@ def validate_allocation(document: dict[str, Any]) -> tuple[str, int]:
if not isinstance(status, dict) or status.get("state") != "Allocated":
raise ValueError(f"allocation state is {status.get('state') if isinstance(status, dict) else None!r}, expected 'Allocated'")
game_server = status.get("gameServer")
if not isinstance(game_server, dict):
raise ValueError("allocation did not return a GameServer")
metadata = game_server.get("metadata")
name = metadata.get("name") if isinstance(metadata, dict) else None
# GameServerAllocationStatus is flat: state, gameServerName, address,
# ports, nodeName. It does not embed the allocated GameServer object. This
# validator originally read status.gameServer.metadata.name and
# status.gameServer.status.{address,ports}, and its tests asserted that
# same invented shape, so both agreed with each other and neither agreed
# with Agones -- undetected because the gate never once got far enough to
# allocate anything.
name = status.get("gameServerName")
if not isinstance(name, str) or not name.strip():
raise ValueError("allocation GameServer has no metadata.name")
raise ValueError("allocation did not return a gameServerName")
game_status = game_server.get("status")
if not isinstance(game_status, dict):
raise ValueError("allocation GameServer has no status")
address = game_status.get("address")
address = status.get("address")
if not isinstance(address, str) or not address.strip() or any(char.isspace() for char in address):
raise ValueError(f"allocation returned an invalid address: {address!r}")
if address in {"0.0.0.0", "::"}:
raise ValueError(f"allocation returned an unspecified address: {address!r}")
ports = game_status.get("ports")
ports = status.get("ports")
if not isinstance(ports, list):
raise ValueError("allocation GameServer has no ports")
raise ValueError("allocation returned no ports")
game_ports = [
entry.get("port")
for entry in ports