From e23243ff56f499f769645bc05f5d31e6d54c652b Mon Sep 17 00:00:00 2001 From: Josh Creek <8179928+jcreek@users.noreply.github.com> Date: Tue, 1 Sep 2026 12:44:36 +0100 Subject: [PATCH] fix(server): drop extra unused argument in queue ticket insert CreateQueueTicket passed 9 arguments to QueueTicketInsertSQL, which only has 8 placeholders (state is a hardcoded 'QUEUED' literal in the SQL, not $4) -- every real queue-ticket creation against PostgreSQL failed with 'mismatched param and argument count'. Found by actually running the opt-in Postgres integration suite (previously never exercised locally, per its own gating) rather than trusting the unit tests, which mock the driver and can't catch a placeholder-count mismatch. Verified fixed against a real postgres:17-alpine container. --- server/store/queue_sql.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/store/queue_sql.go b/server/store/queue_sql.go index 0f2b7264..dbc0152c 100644 --- a/server/store/queue_sql.go +++ b/server/store/queue_sql.go @@ -150,7 +150,7 @@ func CreateQueueTicket(ctx context.Context, db *sql.DB, ticketID, playerID, idem if err != nil { return err } - _, err = tx.ExecContext(ctx, QueueTicketInsertSQL, ticketID, playerID, string(spec.Playlist), string(domain.Queued), spec.ClientBuild, spec.ProtocolVersion, now, ticket.ExpiresAt, predictedRTT) + _, err = tx.ExecContext(ctx, QueueTicketInsertSQL, ticketID, playerID, string(spec.Playlist), spec.ClientBuild, spec.ProtocolVersion, now, ticket.ExpiresAt, predictedRTT) return err }) return ticket, err