mirror of
https://github.com/jcreek/CosmicClash.git
synced 2026-09-10 16:04:04 +00:00
Josh Creek
61a073099d
Two things that made the integration gate untrustworthy. The retry budget was too small for expected contention. TestPostgreSQLConcurrentIdenticalResultSubmission fires five identical concurrent submissions and requires all five to succeed; it failed 4 runs in 20. The error was retryable and retries did fire -- three attempts simply was not enough. Contention here is normal rather than exceptional: several game servers can submit results, and several matchers can claim candidates, against the same rows at once. Raised to five attempts, which is 0 failures in 40 runs. Also jittered the backoff, but measured rather than assumed: my first theory was a thundering herd, since the delay was exactly RetryBackoff*(attempt+1) and every loser of a race woke at the same instant. Isolating the two changes showed jitter alone moved 4/20 to 3/20, while the budget alone reached 0/20. The budget was the real constraint. Jitter is kept because it costs nothing and its benefit grows with the number of contending writers -- production is not capped at five -- but the comment now says plainly that it is the smaller half, so nobody inherits my wrong explanation. Second, the integration scripts leaked one throwaway database volume per run. --rm does reclaim anonymous volumes on a normal exit, but these scripts force-remove the container from a trap, and `docker rm -f` without -v keeps the volume. Sixty-four accumulated during this branch until PostgreSQL stopped starting, surfacing only as the scripts' own readiness timeout rather than as a disk error -- which is what the "Docker storage exhausted locally" notes were really describing. Measured at one volume per run before, zero after, across all five scripts.
43 lines
1.4 KiB
Bash
Executable File
43 lines
1.4 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
set -euo pipefail
|
|
|
|
repo_root="$(cd "$(dirname "$0")/.." && pwd)"
|
|
container_name="cosmic-clash-postgres-integration"
|
|
database="cosmic_clash_test"
|
|
user="cosmic_clash_test"
|
|
password="cosmic_clash_test"
|
|
|
|
cleanup() {
|
|
# -v matters: the container runs with --rm, which would reclaim its
|
|
# anonymous volume on a normal exit, but this trap force-removes it instead
|
|
# and `docker rm -f` alone leaves the volume behind. Each run then leaks one
|
|
# throwaway database volume, which accumulates silently until the Docker VM
|
|
# disk fills and the next container fails to start -- surfacing only as this
|
|
# script's own readiness timeout, never as a disk error. See
|
|
# multiplayer-next.md §9 gotcha 52.
|
|
docker rm -f -v "$container_name" >/dev/null 2>&1 || true
|
|
}
|
|
trap cleanup EXIT
|
|
|
|
cleanup
|
|
docker run --rm -d --name "$container_name" \
|
|
-e POSTGRES_DB="$database" \
|
|
-e POSTGRES_USER="$user" \
|
|
-e POSTGRES_PASSWORD="$password" \
|
|
-p 55432:5432 postgres:17-alpine >/dev/null
|
|
|
|
for attempt in $(seq 1 30); do
|
|
if docker exec "$container_name" pg_isready -U "$user" -d "$database" >/dev/null 2>&1; then
|
|
break
|
|
fi
|
|
if [ "$attempt" = 30 ]; then
|
|
echo "PostgreSQL did not become ready" >&2
|
|
exit 1
|
|
fi
|
|
sleep 1
|
|
done
|
|
|
|
cd "$repo_root/server"
|
|
COSMIC_CLASH_POSTGRES_DSN="postgres://${user}:${password}@127.0.0.1:55432/${database}?sslmode=disable" \
|
|
go test -tags integration ./store -count=1
|