mirror of
https://github.com/jcreek/CosmicClash.git
synced 2026-09-11 17:13:44 +00:00
Josh Creek
3168dd9897
Found building the two-player proposal integration test (next commit): Worker.Run treated ANY RunOnce error as fatal to the whole loop, including domain.FormFromQueue's "no compatible candidates" -- which is not a failure, it's the completely routine and expected outcome of a queue whose currently-waiting players don't share a verified region yet. Two real players with no common region formed exactly this shape, and the entire matcher process exited -- taking matchmaking down for every OTHER player in the same playlist, not just the incompatible pair, since cmd/matcher runs one process per playlist. Worse: on a real supervisor restart, the same still-incompatible candidates are still queued, so it would crash again immediately -- an actual crash loop, not a one-off. RunOnce's own per-call contract (return an error for source failure, bad formation, mixed playlist, an incomplete batch, a lost durable claim) is deliberately tested and unchanged. The fix is entirely in Run's loop: only the three genuinely static misconfiguration errors (nil dependencies, unsupported playlist, invalid size -- true on every future pass just as much as this one, so retrying can never help) now stop it, via new exported sentinels (ErrWorkerNotConfigured, ErrUnsupportedPlaylist, ErrInvalidMatcherSize) and errors.Is. Every other RunOnce error is a single pass's worth of "no match formed this time" and Run keeps polling. Covered by two new tests: Run recovering from a first-pass error and still forming a proposal once the pool becomes viable (a real concurrent goroutine driving Run, not just calling RunOnce directly -- Run's own loop had no test coverage at all before this), and Run still stopping immediately on a genuine configuration error. Both clean across 3 runs with -race.