refactor(#91): Address PR comments

This commit is contained in:
Josh Creek
2026-06-16 15:46:12 +01:00
parent 8255fb4c67
commit 19e4d7b727
2 changed files with 4 additions and 4 deletions
@@ -131,7 +131,7 @@ class CombinedDataRepository {
query = query.eq('regionToCatchIn', region); query = query.eq('regionToCatchIn', region);
} }
const { data, error } = await query.range(start, end); const { data, error } = await query.order('id', { ascending: true }).range(start, end);
if (error) { if (error) {
console.error('Error fetching forms for game:', error); console.error('Error fetching forms for game:', error);
@@ -75,11 +75,11 @@ CROSS JOIN games g
WHERE p.pokemon = 'Rotom' WHERE p.pokemon = 'Rotom'
AND p.form IN ('Fan', 'Fridge', 'Lightbulb', 'Mower', 'Oven', 'Washer') AND p.form IN ('Fan', 'Fridge', 'Lightbulb', 'Mower', 'Oven', 'Washer')
AND g."displayName" IN ( AND g."displayName" IN (
'Heart Gold', 'Soul Silver', 'Platinum', 'Heart Gold', 'Soul Silver',
'Black', 'White', 'Black 2', 'White 2', 'Black', 'White', 'Black 2', 'White 2',
'X', 'Y', 'Omega Ruby', 'Alpha Sapphire', 'X', 'Y', 'Omega Ruby', 'Alpha Sapphire',
'Sun', 'Moon', 'Ultra Sun', 'Ultra Moon', 'Sun', 'Moon', 'Ultra Sun', 'Ultra Moon',
'Sword', 'Shield', 'Sword', 'Shield', 'Brilliant Diamond', 'Shining Pearl',
'Scarlet', 'Violet' 'Scarlet', 'Violet'
) )
ON CONFLICT DO NOTHING; ON CONFLICT DO NOTHING;
@@ -150,7 +150,7 @@ SELECT p.id, g.id
FROM pokemon p FROM pokemon p
CROSS JOIN games g CROSS JOIN games g
WHERE p.pokemon = 'Shaymin' AND p.form = 'Sky Form' WHERE p.pokemon = 'Shaymin' AND p.form = 'Sky Form'
AND g."displayName" IN ('Heart Gold', 'Soul Silver', 'X', 'Y', 'Scarlet', 'Violet') AND g."displayName" IN ('Platinum', 'Heart Gold', 'Soul Silver', 'X', 'Y', 'Scarlet', 'Violet')
ON CONFLICT DO NOTHING; ON CONFLICT DO NOTHING;
-- Hoopa Confined: distributed via Mystery Gift for all Gen 6 games (X/Y + OR/AS). -- Hoopa Confined: distributed via Mystery Gift for all Gen 6 games (X/Y + OR/AS).