test: make the suite's assertions falsifiable and its state isolated

Several assertions could not fail:

- "the catch update remains saved" was `caught.isChecked() || notes.includes(...)`
  shared by two scenarios, so either half satisfied both. Split into two steps
  that each assert the outcome their own scenario is about.
- The token-refresh check read a global counter with `> 0` and asserted an upload
  had happened `some(...)`, both already satisfied by the preceding scenario. It
  now asserts exactly one refresh, ordered before the upload.
- The box step ignored its box argument and asserted on the first N entries on
  the page; it now scopes to that box and checks its full contents.
- The filter step asserted on whichever entry was first after filtering; it now
  records the caught entry beforehand and names it, and checks the filter did not
  exclude everything.
- The empty-state precondition asserted emptiness instead of establishing it,
  which a fresh user satisfies for free.
- Offline coverage was `caches.keys().length > 0`. It now checks the precache
  contract: one workbox cache holding the shell and a revisioned web manifest,
  with _app/immutable assets cached without a revision query. The scenario that
  claimed to test a trailing slash did not; it is replaced with real offline
  client-side navigation.

The mock provider kept recorded requests, its refresh counter and the
fail-uploads switch in one process-wide object that only one step reset, so
scenario order was load-bearing and the failing-upload scenario poisoned
everything after it. An auto fixture now resets it per scenario, and the mock no
longer records its own control-plane calls. That reset is why the suite stays on
a single worker, which is now documented.

Coverage was gated at 90% per file over an allowlist of exactly the five files
that had tests, so new code was invisible to it permanently. It now measures all
of src/lib with global thresholds at the measured baseline, and no longer runs
the unit tests twice.

Also: a global teardown removes the users each run creates, the Supabase wrapper
distinguishes a stopped stack from a broken CLI call and detects an unseeded
database, the sign-in rate limit is raised above what one serial run needs, and
the integration suite no longer falls back to a hard-coded anon key that would
mask a misconfigured run.

The password-reset scenarios are renamed to what they actually cover: following a
real recovery link bounces to /signin, because the browser client persists no
cookies and so cannot keep the session it parses out of the URL. The helper for
the real flow is left in place and the gap is documented.
This commit is contained in:
Josh Creek
2026-09-13 17:36:36 +01:00
parent 3a2c18bbeb
commit 4af33709a3
27 changed files with 406 additions and 102 deletions
+38 -14
View File
@@ -72,7 +72,6 @@ When('I visit backup settings', async ({ page }) => {
});
When('I connect the mocked {string} provider', async ({ page }, provider: string) => {
await fetch(`${MOCK_URL}/__mock/reset`);
await page.goto('/backup-settings');
const card = page.locator('.card, .border').filter({ hasText: provider }).last();
await card.getByRole('button', { name: 'Connect' }).click();
@@ -125,29 +124,54 @@ Then('the backup connection is rejected', async ({ state }) => {
expect(state.lastResponseStatus).toBe(400);
});
Then('the mocked provider receives a valid escaped CSV', async () => {
async function mockState() {
const response = await fetch(`${MOCK_URL}/__mock/state`);
const mock = (await response.json()) as { requests: Array<{ path: string; body: string }> };
const upload = mock.requests.find((request) => request.path.includes('upload'));
expect(upload?.body).toContain('"A comma, and a ""quote"""');
if (!response.ok) throw new Error(`Mock provider is unavailable: ${response.status}`);
return (await response.json()) as {
refreshes: number;
requests: Array<{ method: string; path: string; body: string }>;
};
}
Then('the mocked provider receives a valid escaped CSV', async () => {
const { requests } = await mockState();
const upload = requests.find((request) => request.path.includes('upload'));
expect(upload, 'no upload reached the mock provider').toBeDefined();
expect(upload!.body).toContain('"A comma, and a ""quote"""');
});
Then('the catch update remains saved', async ({ page, state }) => {
Then('the note survives a reload', async ({ page, state }) => {
await page.goto(`/pokedex/${state.pokedexId}`);
await expect(firstPokemon(page)).toBeVisible();
await openFirstPokemon(page);
const dialog = page.getByRole('dialog');
const caught = dialog.getByText('Caught:', { exact: true }).locator('..').getByRole('checkbox');
const notes = dialog.getByLabel('Notes:');
expect((await caught.isChecked()) || (await notes.inputValue()).includes('comma')).toBe(true);
await expect(page.getByRole('dialog').getByLabel('Notes:')).toHaveValue('A comma, and a "quote"');
});
Then('the catch remains marked caught', async ({ page, state }) => {
await page.goto(`/pokedex/${state.pokedexId}`);
await expect(firstPokemon(page)).toBeVisible();
await openFirstPokemon(page);
const caught = page
.getByRole('dialog')
.getByText('Caught:', { exact: true })
.locator('..')
.getByRole('checkbox');
await expect(caught).toBeChecked();
});
Then('the token is refreshed before the mocked upload', async ({ state }) => {
expect(state.lastResponseStatus).toBe(200);
const response = await fetch(`${MOCK_URL}/__mock/state`);
const mock = (await response.json()) as { refreshes: number; requests: Array<{ path: string }> };
expect(mock.refreshes).toBeGreaterThan(0);
expect(mock.requests.some((request) => request.path.includes('upload'))).toBe(true);
const { refreshes, requests } = await mockState();
// Exactly one refresh, and it has to come before the upload it was needed for - a global
// ">= 1" would be satisfied by any earlier scenario's traffic.
expect(refreshes).toBe(1);
const refreshIndex = requests.findIndex(
(request) =>
request.path.endsWith('/token') && request.body.includes('grant_type=refresh_token')
);
const uploadIndex = requests.findIndex((request) => request.path.includes('upload'));
expect(refreshIndex).toBeGreaterThanOrEqual(0);
expect(uploadIndex).toBeGreaterThan(refreshIndex);
});
Then('the provider failure is shown in backup settings', async ({ page }) => {