From 7c68d121cedcbe22f87c9e603f7f5483ed96809f Mon Sep 17 00:00:00 2001
From: Josh Creek <8179928+jcreek@users.noreply.github.com>
Date: Sat, 10 Jan 2026 16:27:23 +0000
Subject: [PATCH] fix(#64): Address PR comments

---
 src/lib/components/SignUp.svelte                   |  4 ++--
 src/routes/+page.svelte                            | 14 +++++++-------
 ...20260110120001_create_update_stats_function.sql | 14 ++++++++------
 ...0260110144000_fix_stats_functions_ambiguity.sql |  9 +++++----
 4 files changed, 22 insertions(+), 19 deletions(-)

diff --git a/src/lib/components/SignUp.svelte b/src/lib/components/SignUp.svelte
index 8dfd226..09951f4 100644
--- a/src/lib/components/SignUp.svelte
+++ b/src/lib/components/SignUp.svelte
@@ -54,11 +54,11 @@
 		/>
 	</div>
 	<div class="form-control mt-6">
-		<button class="btn btn btn-primary" on:click={signUpNewUser}>Sign Up</button>
+		<button class="btn btn-primary" on:click={signUpNewUser}>Sign Up</button>
 	</div>
 </form>
 
-<style scoped>
+<style>
 	.card-body {
 		padding: 0.5rem;
 	}
diff --git a/src/routes/+page.svelte b/src/routes/+page.svelte
index 6a61202..575dd80 100644
--- a/src/routes/+page.svelte
+++ b/src/routes/+page.svelte
@@ -17,7 +17,7 @@
 	// Format large numbers (e.g., 1000 -> 1K, 1000000 -> 1M)
 	function formatNumber(num: number): string {
 		if (num >= 1000000) {
-			return (num / 1000000).toFixed(1).replace(/.0$/, '') + 'M';
+			return (num / 1000000).toFixed(1).replace(/\.0$/, '') + 'M';
 		}
 		if (num >= 1000) {
 			return (num / 1000).toFixed(0) + 'K';
@@ -30,9 +30,9 @@
 	let users = '0';
 	let livingDexesCompleted = '0';
 	$: {
-		pokemonCaught = stats ? formatNumber(stats.pokemonCaught) : '0';
-		users = stats ? formatNumber(stats.users) : '0';
-		livingDexesCompleted = stats ? formatNumber(stats.livingDexesCompleted) : '0';
+		pokemonCaught = formatNumber(stats?.pokemonCaught ?? 0);
+		users = formatNumber(stats?.users ?? 0);
+		livingDexesCompleted = formatNumber(stats?.livingDexesCompleted ?? 0);
 	}
 </script>
 
@@ -188,7 +188,7 @@
 <!-- Features Section -->
 <div class="py-16 bg-base-200">
 	<div class="container mx-auto px-4 max-w-6xl">
-		<h1 class="text-4xl font-bold mb-12 text-center">Why Choose Living Dex Tracker?</h1>
+		<h2 class="text-4xl font-bold mb-12 text-center">Why Choose Living Dex Tracker?</h2>
 
 		<div class="grid md:grid-cols-2 gap-6">
 			<div class="card bg-neutral shadow-xl">
@@ -318,8 +318,8 @@
 	<div class="container mx-auto px-4 text-center">
 		<h2 class="text-4xl font-bold mb-6">Ready to Start Your Journey?</h2>
 		<p class="text-xl mb-8 text-base-content/80 max-w-2xl mx-auto">
-			Get started today with tracking you Living Pokédex progress. It's free, open source, and built
-			with love for the Pokémon community.
+			Get started today with tracking your Living Pokédex progress. It's free, open source, and
+			built with love for the Pokémon community.
 		</p>
 		<div class="flex flex-wrap gap-4 justify-center">
 			<div class="card shrink-0 w-full max-w-sm shadow-2xl bg-neutral">
diff --git a/supabase/migrations/20260110120001_create_update_stats_function.sql b/supabase/migrations/20260110120001_create_update_stats_function.sql
index 6d9c285..da368f6 100644
--- a/supabase/migrations/20260110120001_create_update_stats_function.sql
+++ b/supabase/migrations/20260110120001_create_update_stats_function.sql
@@ -9,12 +9,14 @@ RETURNS TABLE (
   updated_at TIMESTAMPTZ
 )
 SECURITY DEFINER
+SET search_path = public, pg_temp
 LANGUAGE plpgsql
 AS $$
 DECLARE
   v_pokemon_caught BIGINT;
   v_total_users BIGINT;
   v_completed_pokedexes BIGINT;
+  v_updated_at TIMESTAMPTZ := NOW();
 BEGIN
   -- Calculate current stats: count of caught Pokémon
   SELECT COUNT(*) INTO v_pokemon_caught
@@ -29,23 +31,23 @@ BEGIN
   -- A pokedex is completed when all its entries have caught = true
   SELECT COUNT(*) INTO v_completed_pokedexes
   FROM (
-    SELECT pokedexId
+    SELECT "pokedexId"
     FROM catch_records
-    GROUP BY pokedexId
+    GROUP BY "pokedexId"
     HAVING COUNT(*) = COUNT(*) FILTER (WHERE caught = true)
   ) completed;
 
   -- Update cache using UPSERT pattern
-  INSERT INTO stats_cache (pokemon_caught, total_users, completed_pokedexes, updated_at)
-  VALUES (v_pokemon_caught, v_total_users, v_completed_pokedexes, NOW())
+  INSERT INTO stats_cache (id, pokemon_caught, total_users, completed_pokedexes, updated_at)
+  VALUES (1, v_pokemon_caught, v_total_users, v_completed_pokedexes, v_updated_at)
   ON CONFLICT (id) DO UPDATE
   SET pokemon_caught = EXCLUDED.pokemon_caught,
       total_users = EXCLUDED.total_users,
       completed_pokedexes = EXCLUDED.completed_pokedexes,
-      updated_at = NOW();
+      updated_at = v_updated_at;
 
   -- Return the stats
   RETURN QUERY
-  SELECT v_pokemon_caught, v_total_users, v_completed_pokedexes, NOW() AS updated_at;
+  SELECT v_pokemon_caught, v_total_users, v_completed_pokedexes, v_updated_at AS updated_at;
 END;
 $$;
diff --git a/supabase/migrations/20260110144000_fix_stats_functions_ambiguity.sql b/supabase/migrations/20260110144000_fix_stats_functions_ambiguity.sql
index b557244..106d302 100644
--- a/supabase/migrations/20260110144000_fix_stats_functions_ambiguity.sql
+++ b/supabase/migrations/20260110144000_fix_stats_functions_ambiguity.sql
@@ -18,6 +18,7 @@ DECLARE
   v_pokemon_caught BIGINT;
   v_total_users BIGINT;
   v_completed_pokedexes BIGINT;
+  v_updated_at TIMESTAMPTZ := NOW();
 BEGIN
   -- Calculate current stats: count of caught Pokémon
   SELECT COUNT(*) INTO v_pokemon_caught
@@ -39,17 +40,17 @@ BEGIN
   ) completed;
 
   -- Update cache using UPSERT pattern
-  INSERT INTO stats_cache (pokemon_caught, total_users, completed_pokedexes, updated_at)
-  VALUES (v_pokemon_caught, v_total_users, v_completed_pokedexes, NOW())
+  INSERT INTO stats_cache (id, pokemon_caught, total_users, completed_pokedexes, updated_at)
+  VALUES (1, v_pokemon_caught, v_total_users, v_completed_pokedexes, v_updated_at)
   ON CONFLICT (id) DO UPDATE
   SET pokemon_caught = EXCLUDED.pokemon_caught,
       total_users = EXCLUDED.total_users,
       completed_pokedexes = EXCLUDED.completed_pokedexes,
-      updated_at = NOW();
+      updated_at = v_updated_at;
 
   -- Return stats
   RETURN QUERY
-  SELECT v_pokemon_caught, v_total_users, v_completed_pokedexes, NOW() AS updated_at;
+  SELECT v_pokemon_caught, v_total_users, v_completed_pokedexes, v_updated_at AS updated_at;
 END;
 $$;