From fa38fa69ca6b5a9fe0253ea9d54f1ba213f37876 Mon Sep 17 00:00:00 2001 From: Josh Creek <8179928+jcreek@users.noreply.github.com> Date: Sat, 26 Jul 2025 19:42:04 +0100 Subject: [PATCH] refactor(*):Address PR comments --- package.json | 3 +- src/lib/components/SignIn.svelte | 22 ++- .../pokedex/PokedexEntryCatchRecord.svelte | 9 +- src/lib/models/CatchRecord.ts | 33 +++-- src/lib/models/PokedexEntry.ts | 64 ++++---- src/lib/repositories/CatchRecordRepository.ts | 80 ++++++---- .../repositories/CombinedDataRepository.ts | 133 +++++++++-------- .../repositories/PokedexEntryRepository.ts | 84 ++++++----- src/routes/api/catch-records/+server.ts | 48 ++++-- src/routes/api/combined-data/+server.ts | 37 +++-- src/routes/api/combined-data/all/+server.ts | 26 +++- src/routes/mydex/+page.svelte | 17 ++- src/routes/mydex/+page.ts | 7 + supabase/config.toml | 2 +- .../20250126000001_initial_setup.sql | 34 ----- .../20250126000002_create_pokemon_schema.sql | 140 +++++++++++------- ...126000002_create_pokemon_schema.sql.backup | 130 ++++++++++++++++ ...0126000002_create_pokemon_schema_fixed.sql | 133 +++++++++++++++++ .../20250126000003_seed_pokemon_data.sql | 54 ------- .../20250126000004_seed_full_pokemon_data.sql | 83 ++++++++--- supabase/seed.sql | 14 -- tsconfig.json | 8 +- 22 files changed, 749 insertions(+), 412 deletions(-) create mode 100644 src/routes/mydex/+page.ts delete mode 100644 supabase/migrations/20250126000001_initial_setup.sql create mode 100644 supabase/migrations/20250126000002_create_pokemon_schema.sql.backup create mode 100644 supabase/migrations/20250126000002_create_pokemon_schema_fixed.sql delete mode 100644 supabase/migrations/20250126000003_seed_pokemon_data.sql delete mode 100644 supabase/seed.sql diff --git a/package.json b/package.json index 04f6306..77633d9 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "name": "LivingDexTracker", + "name": "livingdextracker", "version": "0.0.1", "private": true, "scripts": { @@ -29,7 +29,6 @@ "supabase:reset": "supabase db reset", "supabase:studio": "supabase studio", "migrate:convert-tsv": "node scripts/convert-tsv-to-sql.js", - "migrate:from-mongo": "echo 'MongoDB to Supabase migration complete! Use new supabase endpoints.'", "dev:local": "./scripts/dev-local.sh && npm run dev", "dev:supabase": "supabase start && npm run dev" }, diff --git a/src/lib/components/SignIn.svelte b/src/lib/components/SignIn.svelte index 430fb00..5bd0aed 100644 --- a/src/lib/components/SignIn.svelte +++ b/src/lib/components/SignIn.svelte @@ -13,15 +13,25 @@ export let supabase: any; async function signInWithEmail() { - // TODO use the data and error from the response - const { data, error } = await supabase.auth - .signInWithPassword({ + try { + const { data, error } = await supabase.auth.signInWithPassword({ email: email, password: password - }) - .then(() => { - emitSignedInEvent(); }); + + if (error) { + console.error('Sign in error:', error); + alert(`Sign in failed: ${error.message}`); + return; + } + + if (data) { + emitSignedInEvent(); + } + } catch (err) { + console.error('Sign in error:', err); + alert('Sign in failed'); + } } diff --git a/src/lib/components/pokedex/PokedexEntryCatchRecord.svelte b/src/lib/components/pokedex/PokedexEntryCatchRecord.svelte index 000ab4a..39f28b3 100644 --- a/src/lib/components/pokedex/PokedexEntryCatchRecord.svelte +++ b/src/lib/components/pokedex/PokedexEntryCatchRecord.svelte @@ -12,8 +12,8 @@ // Create a working copy for editing $: workingCatchRecord = catchRecord || { - _id: '', - userId: '', + _id: `temp-${Date.now()}-${pokedexEntry._id}`, // Generate temporary ID + userId: '', // TODO: Get from session context pokedexEntryId: pokedexEntry._id, haveToEvolve: false, caught: false, @@ -136,8 +136,9 @@ {/if}

- Notes: