jcreek/LivingDexTracker
1
0
Fork 0
mirror of https://github.com/jcreek/LivingDexTracker.git synced 2026-09-16 10:32:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(backup): pause revoked backups and tell users to reconnect

Browse Source 
Google answers a revoked or expired refresh token with invalid_grant.
Every save then retried the dead token, and reconnecting never cleared
the old error, so it kept showing on Backup Settings afterwards.

- The Google Drive and Dropbox OAuth callbacks clear lastError when a
  provider is reconnected.
- An invalid_grant, or a missing refresh token, now pauses the
  integration with a readable "reconnect" message instead of retrying
  it on every catch update. Other failures still retry as before.
- A banner on every page and an alert on the Pokédex page point to
  Backup Settings, which shows a "Reconnect needed" badge. The Pokédex
  page re-checks backup status after each export, because saving a
  catch record also exports on the server and may pause a provider
  first.
- Offline sync status and the "Save all artwork" link move from every
  page to a new /offline-guide page, linked from the user menu and the
  home and welcome pages. Only the offline read-only banner stays
  sitewide.
- Unit tests cover every export path and the backup status store. BDD
  covers revocation and reconnecting for both providers, and the
  offline guide. The mock provider can now reject token refreshes, and
  mock control calls fail loudly if a stale mock is reused. Coverage
  thresholds are raised to the new baseline.
This commit is contained in:
Josh Creek
2026-09-14 18:42:10 +01:00
parent 5c25a763c0
commit fb95b43b30
21 changed files with 1105 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/bdd/features/backup-export.feature
+26
View File
@@ -40,3 +40,29 @@ Feature: Backup and export
When I update collection progress
Then the catch remains marked caught
And the provider failure is shown in backup settings
And "Google Drive" is not flagged for reconnection
Scenario Outline: Warn when a provider's access is revoked
Given "<provider>" is connected with a revoked refresh token
When I update collection progress
Then the Pokédex page tells me to reconnect "<provider>"
And I can dismiss the reconnect alert
And backup settings asks me to reconnect "<provider>"
And other pages warn that my "<provider>" backup has stopped
And later exports do not retry the revoked token
Examples:
| provider |
| Google Drive |
| Dropbox |
Scenario Outline: Reconnecting clears a previous backup error
Given "<provider>" previously lost access
When I connect the mocked "<provider>" provider
Then "<provider>" is shown as connected
And the previous backup error is cleared
Examples:
| provider |
| Google Drive |
| Dropbox |