refactor(#35): add keys to navlink loops

This commit is contained in:
OllyNicholass
2024-10-29 21:29:09 +00:00
parent 4be732005e
commit 00fb76ca4f
3 changed files with 5 additions and 3 deletions
+2
View File
@@ -21,6 +21,7 @@
</script> </script>
<nav class="bg-primary text-primary-content p-4"> <nav class="bg-primary text-primary-content p-4">
<!-- Nav Container -->
<div class="container mx-auto flex justify-between items-center"> <div class="container mx-auto flex justify-between items-center">
<!-- Hamburger Menu Button (Mobile) --> <!-- Hamburger Menu Button (Mobile) -->
<div class="lg:hidden mr-4"> <div class="lg:hidden mr-4">
@@ -47,6 +48,7 @@
<NavLinks isMobile {session} {supabase} /> <NavLinks isMobile {session} {supabase} />
</Dropdown> </Dropdown>
</div> </div>
<!-- Logo -->
<a href="/" class="text-white font-bold text-xl">SvelteKit SaaS Boilerplate</a> <a href="/" class="text-white font-bold text-xl">SvelteKit SaaS Boilerplate</a>
<div class="hidden lg:block"> <div class="hidden lg:block">
<NavLinks {session} /> <NavLinks {session} />
@@ -17,7 +17,7 @@
{#if !isMobile} {#if !isMobile}
<Dropdown indicator> <Dropdown indicator>
<div slot="dropdown">{linkItem.text}</div> <div slot="dropdown">{linkItem.text}</div>
{#each linkItem.children ?? [] as child} {#each linkItem.children ?? [] as child (child.text.replace(' ', '-').toLowerCase())}
<li><NavLink linkItem={child} /></li> <li><NavLink linkItem={child} /></li>
{/each} {/each}
</Dropdown> </Dropdown>
@@ -34,7 +34,7 @@
class="menu-dropdown menu-dropdown-show" class="menu-dropdown menu-dropdown-show"
transition:slide={{ duration: 200, easing: cubicInOut }} transition:slide={{ duration: 200, easing: cubicInOut }}
> >
{#each linkItem.children ?? [] as child} {#each linkItem.children ?? [] as child (child.text.replace(' ', '-').toLowerCase())}
<li><NavLink linkItem={child} {supabase} /></li> <li><NavLink linkItem={child} {supabase} /></li>
{/each} {/each}
</ul> </ul>
@@ -67,7 +67,7 @@
</script> </script>
<ul class:flex={!isMobile} class:space-x-4={!isMobile}> <ul class:flex={!isMobile} class:space-x-4={!isMobile}>
{#each links as link} {#each links as link (link.text.replace(' ', '-').toLowerCase())}
<li class:md:hidden={link.isUserAccount}> <li class:md:hidden={link.isUserAccount}>
{#if link.isParent} {#if link.isParent}
<NavLinkParent linkItem={link} {isMobile} {supabase} /> <NavLinkParent linkItem={link} {isMobile} {supabase} />