From 0ccf04fcbce10da4942a0f1d09e819d1f15cce60 Mon Sep 17 00:00:00 2001
From: OllyNicholass <OllyNicholass@users.noreply.github.com>
Date: Mon, 18 Nov 2024 23:03:17 +0000
Subject: [PATCH] refactor(#35): accessible navlinks

---
 src/lib/components/navigation/NavLink.svelte       | 6 +++++-
 src/lib/components/navigation/NavLinkParent.svelte | 1 +
 src/lib/components/navigation/NavLinks.svelte      | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/lib/components/navigation/NavLink.svelte b/src/lib/components/navigation/NavLink.svelte
index 5f26370..dbcb775 100644
--- a/src/lib/components/navigation/NavLink.svelte
+++ b/src/lib/components/navigation/NavLink.svelte
@@ -9,7 +9,11 @@
 </script>
 
 {#if !linkItem.isSignout}
-	<a role="menuitem" href={linkItem.href} aria-current={linkItem.href === $page.url.pathname ? 'page' : undefined}>{linkItem.text}</a>
+	<a
+		role="menuitem"
+		href={linkItem.href}
+		aria-current={linkItem.href === $page.url.pathname ? 'page' : undefined}>{linkItem.text}</a
+	>
 {:else if supabase && linkItem.isSignout}
 	<SignOut {supabase} />
 {/if}
diff --git a/src/lib/components/navigation/NavLinkParent.svelte b/src/lib/components/navigation/NavLinkParent.svelte
index 2b33eb8..b7db981 100644
--- a/src/lib/components/navigation/NavLinkParent.svelte
+++ b/src/lib/components/navigation/NavLinkParent.svelte
@@ -30,6 +30,7 @@
 	</button>
 	{#if isOpen}
 		<ul
+			role="menu"
 			class="menu-dropdown menu-dropdown-show"
 			transition:slide={{ duration: 200, easing: cubicInOut }}
 		>
diff --git a/src/lib/components/navigation/NavLinks.svelte b/src/lib/components/navigation/NavLinks.svelte
index aa8a028..25b75ed 100644
--- a/src/lib/components/navigation/NavLinks.svelte
+++ b/src/lib/components/navigation/NavLinks.svelte
@@ -63,7 +63,7 @@
 	];
 </script>
 
-<ul class:flex={!isMobile} class:space-x-4={!isMobile}>
+<ul role="menu" class:flex={!isMobile} class:space-x-4={!isMobile}>
 	{#each links as link (link.text.replace(' ', '-').toLowerCase())}
 		<li class:md:hidden={link.isUserAccount}>
 			{#if link.isParent}