From d6baf11a7c2b42c097e2636d935516d1ff2b8563 Mon Sep 17 00:00:00 2001 From: OllyNicholass Date: Tue, 22 Oct 2024 21:53:44 +0100 Subject: [PATCH] refactor(#35): add guard clause to escape event listener if dropdown is not open --- src/lib/components/Dropdown.svelte | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/lib/components/Dropdown.svelte b/src/lib/components/Dropdown.svelte index d7068e3..150d867 100644 --- a/src/lib/components/Dropdown.svelte +++ b/src/lib/components/Dropdown.svelte @@ -13,10 +13,8 @@ onMount(() => { const handleClick = (event: MouseEvent) => { - if (!dropdown.contains(event.target as Node) && isOpen) { - isOpen = false; - } - if (event.target instanceof HTMLAnchorElement) { + if (!isOpen) return; + if (!dropdown.contains(event.target as Node) || event.target instanceof HTMLAnchorElement) { isOpen = false; } };