mirror of
https://github.com/jcreek/CosmicClash.git
synced 2026-09-11 08:23:45 +00:00
docs(multiplayer): correct two more stale 'remains' notes
Investigating §8.16's 'arena selection... remain' note (looking for the next real Godot-side gap) found the described work was already fully done, not missing: domain.RankedArenaForProposal selects the ranked arena deterministically at proposal time; agones.Client.Allocate already requests it (plus playlist/region/build/protocol/transport) as Agones GameServerAllocation annotations; supervisor.withAllocatedCompatibility already overlays every one of those onto the allocated Godot process's launch command, overriding the Fleet's static per-image defaults -- fully tested (TestWithAllocatedCompatibilityOverridesStaleFlagsAndRejectsUnsafeValues) and wired into Supervisor.Start(). Casual deliberately leaves proposal.ArenaPath empty and the allocated server falls back to its own ArenaRegistry.path_for_match rotation -- the same mechanism the community server already used, always the intended design, not a gap. §8.41's 'dynamic per-match launch flags... remain' note was the same stale claim about the same already-built mechanism, described from the other side (the assignment/roster row instead of the matcher row). Corrected there too, pointing back to §8.16 rather than duplicating the explanation. No code changes -- this is the same category of finding as the crash-loop and connect-wiring fixes earlier this session, just resolved by correcting the record instead of writing new code, since the record was wrong rather than the implementation. Verified the referenced test by name: go test ./supervisor/... -run TestWithAllocatedCompatibilityOverridesStaleFlagsAndRejectsUnsafeValues passes; full go build/vet/test -race clean across every server package (unchanged from before, since only the doc changed).
This commit is contained in:
+2
-2
File diff suppressed because one or more lines are too long
Reference in New Issue
Block a user