mirror of
https://github.com/jcreek/CosmicClash.git
synced 2026-09-11 08:23:45 +00:00
fix(allocator): publish signed assignment rosters before servers start
The root blocker (issue #14). The worker bound the provider allocation and stopped. Service.PublishRoster and store.SaveVerifiedAssignmentRoster both existed, fully tested, with zero non-test callers, and the production allocator configured neither a roster store nor a signing key. Nothing ever wrote the assignments table. The allocated supervisor fetches a non-empty roster before it launches the game child, so every real allocation failed at that fetch: no match could reach ASSIGNMENT_READY or accept a player. Existing tests seeded assignments directly, which is exactly why the missing hand-off went unnoticed. The worker now builds one join authorisation per durable participant, signs each with the active key, and publishes them. Participants are read through the same query SaveVerifiedAssignmentRoster re-validates against, so the allocator cannot construct a roster the persistence boundary would reject. The manifest commits to a digest over the whole roster, so a server cannot be handed a truncated roster whose surviving entries are each individually valid. Persist the provider endpoint on the allocation: it arrived on the provider response and was never stored, so a worker crashing between allocating and publishing had no endpoint to recover and would have stranded the match permanently. Republishing is idempotent, so that crash now simply retries. cmd/allocator refuses to start without key material rather than running an allocator that binds allocations and silently strands every match. The k8s allocator Deployment mounts the same key set the Fleet does, and both now take the JSON key map so a rotation can publish several. New integration test drives the real worker through to the supervisor's own roster read path without seeding the assignments table. Verified it fails with "assignments = 0, want 2" when the publish step is removed.
This commit is contained in:
@@ -1,9 +1,12 @@
|
||||
package domain
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"crypto/hmac"
|
||||
"crypto/sha256"
|
||||
"encoding/hex"
|
||||
"fmt"
|
||||
"sort"
|
||||
"time"
|
||||
)
|
||||
|
||||
@@ -56,3 +59,54 @@ func (r *RankedConnections) AdmitSigned(signed SignedJoinAuthorisation, verify f
|
||||
}
|
||||
return r.Admit(signed.Authorisation, now)
|
||||
}
|
||||
|
||||
// AssignmentRosterDigest binds a manifest to the exact roster it was issued
|
||||
// with. Signing each authorisation individually proves each claim, but the
|
||||
// manifest also has to commit to the set, so a server cannot be handed a
|
||||
// truncated roster whose entries are each individually valid.
|
||||
//
|
||||
// Entries are hashed in slot order so the digest is independent of the order
|
||||
// the caller happened to build them in.
|
||||
func AssignmentRosterDigest(roster []SignedJoinAuthorisation) (string, error) {
|
||||
if len(roster) == 0 {
|
||||
return "", ErrJoinAuthorisation
|
||||
}
|
||||
ordered := make([]SignedJoinAuthorisation, len(roster))
|
||||
copy(ordered, roster)
|
||||
sort.Slice(ordered, func(i, j int) bool {
|
||||
return ordered[i].Authorisation.Slot < ordered[j].Authorisation.Slot
|
||||
})
|
||||
digest := sha256.New()
|
||||
for _, signed := range ordered {
|
||||
if signed.Authorisation.PlayerID == "" {
|
||||
return "", ErrJoinAuthorisation
|
||||
}
|
||||
digest.Write(JoinAuthorisationBytes(signed.Authorisation))
|
||||
digest.Write([]byte{0})
|
||||
}
|
||||
return hex.EncodeToString(digest.Sum(nil)), nil
|
||||
}
|
||||
|
||||
// VerifyJoinAuthorisationHMAC builds the verifier the persistence boundary
|
||||
// re-checks each signature with, selecting the key named by the claim. Keys is
|
||||
// key ID to raw key; an unknown ID verifies as false rather than falling back
|
||||
// to any other key.
|
||||
func VerifyJoinAuthorisationHMAC(keys map[string][]byte) func([]byte, []byte) bool {
|
||||
return func(claims, signature []byte) bool {
|
||||
if len(keys) == 0 || len(claims) == 0 || len(signature) == 0 {
|
||||
return false
|
||||
}
|
||||
// The key ID is the last NUL-separated field of the canonical bytes.
|
||||
separator := bytes.LastIndexByte(claims, 0)
|
||||
if separator < 0 {
|
||||
return false
|
||||
}
|
||||
key, known := keys[string(claims[separator+1:])]
|
||||
if !known || len(key) == 0 {
|
||||
return false
|
||||
}
|
||||
mac := hmac.New(sha256.New, key)
|
||||
mac.Write(claims)
|
||||
return hmac.Equal(mac.Sum(nil), signature)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user