mirror of
https://github.com/jcreek/CosmicClash.git
synced 2026-09-11 08:23:45 +00:00
Josh Creek
6237a25a69
Found by reading the code, not a failing test: no path anywhere transitioned a queue ticket from PROPOSED back to QUEUED after a proposal was declined. A stranded PROPOSED ticket is invisible to the matcher (ListQueuedCandidates only ever reads state='QUEUED'), still counts as that player's one active ticket (blocking a fresh queue_create), and is renewable forever by an ordinary heartbeat -- a player proposed a match with someone who then declines had no way back into matchmaking without realising, on their own, that they needed to manually cancel first. This affects every participant, not just the decliner: an uninvolved player who never even responded was left stuck by someone else's decision. ProposalDeclineRequeueSQL requeues every participant's ticket, including the decliner's own -- nothing yet enforces the decline cooldown task 8.17 documents as a separate, not-yet-built feature, so leaving anyone behind at PROPOSED today isn't "cooldown behaviour", it's just broken. Once that cooldown exists it can exempt the decliner from this immediate requeue; today nothing does. Covered by a real PostgreSQL integration test: after one player declines, both the decliner's and an uninvolved participant's tickets land back at QUEUED with a refreshed expiry, and -- the actual end-to-end regression -- both are visible again to ListQueuedCandidates, the same query the matcher itself uses. Clean across 5 runs, plus the full integration and unit suites.
37 lines
1.6 KiB
Go
37 lines
1.6 KiB
Go
package store
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestProposalRecoverySQLBindsParticipantAndExpiresAtReadBoundary(t *testing.T) {
|
|
for query, fragments := range map[string][]string{
|
|
ProposalExpireSQL: {"state = 'OPEN'", "expires_at <= $2", "revision = revision + 1"},
|
|
ProposalParticipantExpireSQL: {"response = 'PENDING'", "response = 'TIMED_OUT'", "proposals.expires_at <= $2"},
|
|
ProposalRecoverySelectSQL: {"proposal_id = $1", "player_id = $2", "EXISTS"},
|
|
ProposalParticipantsSelectSQL: {"proposal_id = $1", "ORDER BY player_id"},
|
|
ProposalResponseIdempotencyInsertSQL: {"ON CONFLICT (scope, idempotency_key) DO NOTHING", "payload_digest"},
|
|
ProposalLockSQL: {"proposal_id = $1", "FOR UPDATE"},
|
|
ProposalParticipantLockSQL: {"proposal_id = $1", "player_id = $2", "FOR UPDATE"},
|
|
ProposalParticipantRespondSQL: {"response = 'PENDING'", "responded_at"},
|
|
ProposalRevisionBumpSQL: {"revision = revision + 1", "state = 'OPEN'"},
|
|
ProposalDeclineRequeueSQL: {"SET state = 'QUEUED'", "state = 'PROPOSED'", "proposal_participants"},
|
|
} {
|
|
for _, fragment := range fragments {
|
|
if !contains(query, fragment) {
|
|
t.Fatalf("query %q missing %q", query, fragment)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestProposalRecoveryRejectsMissingAuthorityInputs(t *testing.T) {
|
|
if _, err := GetProposal(nil, nil, "player-1", "proposal-1", time.Unix(1000, 0)); err == nil {
|
|
t.Fatal("nil database accepted")
|
|
}
|
|
if _, err := GetProposal(nil, nil, "", "proposal-1", time.Unix(1000, 0)); err == nil {
|
|
t.Fatal("empty player accepted")
|
|
}
|
|
}
|