fix: remediate branch review findings

This commit is contained in:
Josh Creek
2026-09-14 11:47:58 +01:00
parent 4af33709a3
commit 86f1c21e4d
38 changed files with 65833 additions and 58545 deletions
+17 -3
View File
@@ -26,22 +26,36 @@ Feature: Account access
Scenario: Sign out
Given I am signed in
And my offline copy is synchronized
When I sign out
Then I return to the public home page
And my offline copy is removed
Scenario: Keep the session when sign out fails
Given I am signed in
And my offline copy is synchronized
When the sign-out request fails
Then I remain signed in with an error
And my offline copy remains
Scenario: Request a password reset
Given I have a confirmed account
When I request a password reset
Then a password reset email is captured locally
Scenario: Reject a normal session on the recovery page
Given I am signed in
When I visit the password recovery page directly
Then the replacement password form is unavailable
@product-review
Scenario: Reject mismatched replacement passwords
Given I am signed in on the password reset page
Given I follow a valid password reset link
When I enter two different replacement passwords
Then I am told that the passwords do not match
Scenario: Complete a password reset
Given I am signed in on the password reset page
Given I follow a valid password reset link
When I enter a valid replacement password
Then I am told that my password was updated
And only the replacement password signs me in
-1
View File
@@ -40,4 +40,3 @@ Feature: Backup and export
When I update collection progress
Then the catch remains marked caught
And the provider failure is shown in backup settings
@@ -29,4 +29,3 @@ Feature: Pokédex composition
Given I have a Form Dex named "Black Forms" scoped to game "Black" and dex "Unova"
When I inspect its entries with forms
Then Rotom includes its named default form without duplicate forms
@@ -54,4 +54,3 @@ Feature: Pokédex lifecycle
Given another trainer has a Pokédex
When I request the other trainer's Pokédex
Then the Pokédex is not disclosed
@@ -35,4 +35,3 @@ Feature: Progress tracking
When I select the "Compact" box layout
And I reload the Pokédex
Then the "Compact" box layout remains selected
+12 -4
View File
@@ -7,16 +7,24 @@ Feature: Offline-friendly application
When I open the built application
Then a service worker controls the page
And the application shell is precached
And no legacy service worker is requested
Scenario: Reload the home page while offline
Given I have opened the built application online
When I go offline and reload the home page
Then the application remains available
Then the read-only offline viewer is available
Scenario: Navigate to another route while offline
Scenario: Reload a nested route while offline
Given I have opened the built application online
When I go offline and navigate to the sign-in page
Then the sign-in form is available offline
When I go offline and reload the sign-in page
Then the read-only offline viewer is available
Scenario: Read a synchronized collection offline
Given I am signed in
And I have a Living Dex named "Offline Collection"
And my offline copy is synchronized
When I go offline and reload the current Pokédex
Then the offline copy contains "Offline Collection"
Scenario: Restore network access
Given I have opened the built application online